Skip to content

feat/new edit flow monorepo #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dnishiyama wants to merge 12 commits into
base: dev
Choose a base branch
from
Draft

feat/new edit flow monorepo #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0b5dd08
Create new edit flow
dnishiyama Jan 3, 2026
3ec643a
Merge branch 'dev' into feat/new-edit-flow-monorepo
dnishiyama Jan 4, 2026
8a67963
Merge branch 'dev' into feat/new-edit-flow-monorepo
dnishiyama Jan 5, 2026
d1967d7
chore(map): merged branch 'dev' into feat/new-edit-flow-monorepo
elsiedp Apr 21, 2026
c84ee6e
feat(db): update request types and schema for update_requests table
elsiedp Apr 21, 2026
13c3675
fix(env): ensure process.argv is defined before accessing command lin…
elsiedp Apr 21, 2026
39534bd
chore(map): merge branch 'dev' into feat/new-edit-flow-monorepo
elsiedp Apr 21, 2026
036083e
chore(deps): update package versions in pnpm-lock.yaml and clean up u…
elsiedp Apr 21, 2026
e3d4cfb
fix(map): fix lint/type issues
elsiedp Apr 21, 2026
d9005e4
fix(map): fix tests update-request tests
elsiedp Apr 21, 2026
fc3d18e
Merge branch 'dev' into feat/new-edit-flow-monorepo
elsiedp Apr 27, 2026
f341dbd
refactor(map): replace vanillaApi with client and update production e…
elsiedp Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .claude/skills/logs/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ Query Cloud Run logs for any app in this monorepo. Defaults to **auth** on **sta

See `apps.conf` for the full registry. Currently:

| App | Staging Project | Prod Project | Region |
| ------ | ----------------------------- | -------------------- | ------------ |
| `auth` | `f3-authentication-staging` | `f3-authentication` | `us-east1` |
| `api` | `f3-api-472214` | `f3-api-472214` | `us-central1`|
| `map` | `pin-mastery` | `pin-mastery` | `us-central1`|
| App | Staging Project | Prod Project | Region |
| ------ | --------------------------- | ------------------- | ------------- |
| `auth` | `f3-authentication-staging` | `f3-authentication` | `us-east1` |
| `api` | `f3-api-472214` | `f3-api-472214` | `us-central1` |
| `map` | `pin-mastery` | `pin-mastery` | `us-central1` |

## Instructions

Expand Down Expand Up @@ -79,10 +79,10 @@ If there are errors, offer to dig deeper into specific log entries by their `ins

The following app + environment combinations have been verified working:

| App | Staging | Prod | Notes |
| ------ | ------- | ---- | ----- |
| `auth` | ✅ | ✅ | Primary use case — originally built for this app |
| `api` | ✅ | ✅ | GCP project `f3-api-472214`, service names differ per env |
| App | Staging | Prod | Notes |
| ------ | ------- | ---- | ----------------------------------------------------------------------- |
| `auth` | ✅ | ✅ | Primary use case — originally built for this app |
| `api` | ✅ | ✅ | GCP project `f3-api-472214`, service names differ per env |
| `map` | ✅ | ✅ | GCP project `pin-mastery`, Cloud Run service is `f3-2` / `f3-2-staging` |

## Adding a New App
Expand Down
19 changes: 19 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,25 @@
"outFiles": ["${workspaceFolder}/**/*.js"],
"console": "integratedTerminal"
},
{
"name": "Next.js: Full Stack Debug",
"type": "node",
"request": "launch",
"cwd": "${workspaceFolder}/apps/nextjs",
"runtimeExecutable": "pnpm",
"runtimeArgs": ["dev"],
"serverReadyAction": {
Comment on lines +27 to +30

@coderabbitai coderabbitai Bot May 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Debug configuration points to the wrong app directory.

At Line 27, cwd is set to apps/nextjs, but this PR’s app context is apps/map. This launch config will likely fail or target the wrong workspace.

Suggested fix 
-      "cwd": "${workspaceFolder}/apps/nextjs",
+      "cwd": "${workspaceFolder}/apps/map",
       "runtimeExecutable": "pnpm",
-      "runtimeArgs": ["dev"],
+      "runtimeArgs": ["dev:inspect"],

Based on learnings: The apps/map directory contains the Next.js 15 map UI (port 3000).

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"cwd": "${workspaceFolder}/apps/nextjs",
"runtimeExecutable": "pnpm",
"runtimeArgs": ["dev"],
"serverReadyAction": {
"cwd": "${workspaceFolder}/apps/map",
"runtimeExecutable": "pnpm",
"runtimeArgs": ["dev:inspect"],
"serverReadyAction": {
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.vscode/launch.json around lines 27 - 30, Update the debug launch
configuration to target the correct app by changing the "cwd" setting from
"apps/nextjs" to "apps/map" so the runtimeExecutable ("pnpm") and runtimeArgs
(["dev"]) will run the Next.js 15 map UI; verify the "serverReadyAction" and any
port settings still match the app (port 3000) after the cwd change.

"pattern": "started server on .+, url: (https?://.+)",
"uriFormat": "%s",
"action": "debugWithChrome"
},
"skipFiles": ["<node_internals>/**"],
"outFiles": ["${workspaceFolder}/**/*.js"],
"console": "integratedTerminal",
"env": {
"NODE_OPTIONS": "--inspect"
}
},
{
"type": "node",
"request": "launch",
Expand Down
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

- Use Node >=24.14 (see `.nvmrc`), pnpm 10, and Turborepo for workspace orchestration.
- The `apps/map` directory contains the Next.js 15 map UI (port 3000).
- Shared code is organized in `packages/`: `api` (tRPC routers), `auth` (auth helpers), `db` (Drizzle schema/migrations), `ui` (shared components), `validators` (Zod schemas), and `shared` (utilities).
- Shared code is organized in `packages/`: `api` (oRPC routers), `auth` (auth helpers), `db` (Drizzle schema/migrations), `ui` (shared components), `validators` (Zod schemas), and `shared` (utilities).
- Configuration files are in `tooling/`; pnpm patches go in `patches/`; Turbo generators live in `turbo/`.

## Build, Test, and Development Commands
Expand Down
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,12 @@ Environment variables are application-specific in this monorepo. The `.env` file
- For dev migrations use the `dev_generic` user
- For staging migrations use the `dev_generic` user
- For production migrations use the `f3slackbot` user

# WIP

- ensure we can't submit with no time and no events for new events
- add tests for approvals in the admin portal
- test image issues
- better text of where we're moving aos and regions
- decide which things you can change region and and which you can't

@coderabbitai coderabbitai Bot May 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix duplicated wording in WIP bullet.

Line 188 has a typo (and and) that reduces clarity in the action item.

Suggested doc fix 
-- decide which things you can change region and and which you can't
+- decide which things you can change regions for and which you can't
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- decide which things you can change region and and which you can't
- decide which things you can change regions for and which you can't
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@README.md` at line 188, Fix the duplicated word in the WIP bullet "decide
which things you can change region and and which you can't" by removing the
extra "and" and optionally adding a comma for clarity so it reads e.g. "decide
which things you can change region and which you can't" or "decide which things
you can change, and which you can't"; update the sentence in README.md
accordingly.

- TODO: Think through AO and location appearance
3 changes: 3 additions & 0 deletions apps/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@
"@acme/eslint-config/base",
"@acme/eslint-config/nextjs",
"@acme/eslint-config/react"
],
"ignorePatterns": [
"vitest.config.ts"
]
},
"prettier": "@acme/prettier-config"
Expand Down
Loading
Loading