added template download function#12
Open
theo-krueger wants to merge 1 commit into
Open
Conversation
I thought a simple function to download the template files would help a lot for user comfort. Since internet access is assumed because the script is supposed to be sourced directly from github, a simple download could be enough for now. To avoid bloating the number of lines that have to be changed when you bring out a new version, I also added the current version number into a function, so it can be called both for the download and in the FAIReator. There is an issue left with having the download as part of the function description for FAIReator, since it is technically a different function, and I didn't solve it. Finally, for some reason, git does not recognize that I just added lines in the top, so it at least tells me that I deleted and added everything. The only change I made inside FAIReator is replacing the hard coded version with the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought a simple function to download the template files would help a lot for user comfort.
Since internet access is assumed because the script is supposed to be sourced directly from github, a simple download could be enough for now.
To avoid bloating the number of lines that have to be changed when you bring out a new version, I also added the current version number into a function, so it can be called both for the download and in the FAIReator.
There is an issue left with having the download as part of the function description for FAIReator, since it is technically a different function, and I didn't solve it.
Finally, for some reason, everything is shown to be changed, but it seems to be some change in how whitespace is handled. I didn't manage to fix it, but at least in GitHub Desktop in shows nicely when disabling whitespace changes. The only change I made inside FAIReator is replacing the hard coded version with the function.