Conversation
uv-based setup with dependency caching; SCRFD-dependent tests skip automatically when the model pack is absent, so CI needs no model download.
FANNG1
pushed a commit
that referenced
this pull request
Jul 6, 2026
Review found test_build_embedding_index_small_table failing in environments with a pre-existing Ray cluster: Ray's default init joins it, and the foreign workers cannot deserialize this venv's lance_ray functions. Two-layer fix: - local_ray fixture forces a fresh local cluster from this venv (clears RAY_ADDRESS, shuts down any existing context). - The test is marked `ray` and excluded from the default run via pyproject addopts; run explicitly with `pytest -m ray`. The delete_by_date tests stay in the default suite — compaction is best-effort, so they pass even where Ray is unusable. The CI workflow (cherry-picked from PR #9) runs the default suite as a blocking step and `-m ray` as a non-blocking one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CI:
pyteston every PR and on pushes to main, usingastral-sh/setup-uvwith dependency caching anduv sync --locked.No model download needed — SCRFD-dependent tests (
tests/image/test_detector.py, and the e2e suite from #8 once merged) skip themselves when the InsightFace model pack is absent.Note: this branch is off main, so the first run covers the current 28 tests; after #8 merges, CI covers all 55 including the pipeline e2e chain.