Repository navigation
Pin the build workflow's toolchain to 1.98 - #193
Merged
Merged
Conversation
Contributor
Release PreviewNext version:
0.4.1 (2026-10-04) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #192: the release's Build Binaries job is a reusable workflow call (_release.yml:109 uses ./.github/workflows/build.yml), so it never reads _release.yml's own toolchain step. This pins build.yml:42 the same way. _build-multi.yml is deliberately left floating: it only runs cargo build, where lints never fire. patch-version.yml and _cache-warm.yml likewise: one edits the manifest, the other runs cargo check, and neither compiles with poise's parent_commands in the way that broke the release.
The release must re-run and ship, so merge without [no ci]. CI on this PR validates the pin first.