Repository navigation
deps(poise): pin the rev instead of tracking serenity-next - #200
Merged
Merged
Conversation
The release regenerates the lockfile (patch-version.yml runs cargo generate-lockfile), so a branch pin makes every release build whatever poise HEAD happened to be that day. HEAD moved to 0.7.0 and broke three release runs with E0615 on parent_commands before #194 upgraded the code to match. Pinning the rev makes the regeneration a no-op, so a release can no longer silently jump a major version. All four manifests moved (root plus feed/voice/welcome); each had its own branch pin. Verified: cargo generate-lockfile leaves the poise entry unchanged, cargo build --release --all-features --all-targets on 1.98.1 with a clean target is 0 errors, clippy --workspace --all-features --all-targets -- -D warnings is clean.
Contributor
Release PreviewNext version:
0.4.3 (2026-10-07) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196.
The release regenerates the lockfile, so a branch pin means every release builds whatever poise HEAD was that day. HEAD moved to 0.7.0 and broke three release runs before #194 upgraded the code to match; the committed lockfile only held until the next move.
All four manifests carried their own branch pin (root plus feed/voice/welcome), so all four move to rev a1d0e3e.
Verification:
cargo generate-lockfileleaves the poise entry unchanged (the acceptance criterion)cargo build --release --all-features --all-targetson 1.98.1, clean target: 0 errorsclippy --workspace --all-features --all-targets -- -D warnings: cleanNo release needed: this makes the next one deterministic rather than changing what ships.