Draft
Conversation
leknesh
commented
Sep 23, 2025
| <PropertyGroup> | ||
| <TargetFrameworks>net8.0;net9.0</TargetFrameworks> | ||
| <RootNamespace>Fhi.Authentication</RootNamespace> | ||
| <Version>2.1.0-local3</Version> |
Contributor
Author
There was a problem hiding this comment.
Remove before merge!
jennyhougen
reviewed
Sep 27, 2025
| { | ||
| services.AddTransient<OpenIdConnectCookieEventsForApi>(); | ||
| services.AddTransient<ITokenService, DefaultTokenService>(); | ||
| services.AddTransient<IUserTokenEndpointService, UserTokenEndpointService>(); |
Collaborator
There was a problem hiding this comment.
Trengs Tokenservice i denne lenger? Er jo flyttet opp til sampelet
| @@ -0,0 +1,40 @@ | |||
| using Duende.IdentityModel; | |||
Collaborator
There was a problem hiding this comment.
La oss ta en gjennomgang på denne. Jeg har noen tanker her.
| namespace Fhi.Authentication.Tokens | ||
| { | ||
| // TODO: Need to go through this. Copied from HelseId samples and Duende. Should we handle multiple algorithms? | ||
| // need to figure out what algs, size etc. to support |
Collaborator
There was a problem hiding this comment.
Vi må se litt mer på denne. Mulig ny oppgave. Men skal den være sånn så bør vi la den være private.
| /// </summary> | ||
| /// <returns></returns> | ||
| [Test, Explicit("This test getting DPoP token from HelseID with the TokenService")] | ||
| public async Task RequestDPoPToken() |
Collaborator
There was a problem hiding this comment.
Flytte til akseptanse test?
Kattemat
previously approved these changes
Sep 29, 2025
Contributor
Author
|
@jennyhougen skal jeg skrote denne? Det har vel kommet inn endel endringer som endrer utgangspunktet for denne PR-en? |
Collaborator
|
@leknesh det er ikke mane endringer som påvirker denne. Fortsatt gyldig :). Så hvis du har mulighet hadde det vært fint å fullføre den. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dpop token service was moved from HelseId tool to Authextensions.
Examples of use will be added in codelabs
Note! Breaking change for TokenService, the old implementation was replaced with new functionality. Old implementation probably not used outside the project. It had functionality which could be replaced by Duende UserTokenEndpointService.
RelatesTo https://github.com/orgs/FHIDev/projects/1/views/25?filterQuery=domain%3AApplicationSecurity+&pane=issue&itemId=124468448&issue=FHIDev%7CFhi.Fellesteam%7C219