Skip to content

fix: wait for ROI imports to finish - #3

Merged
zhenyuan992 merged 1 commit into
mainfrom
fix/roi-import-timeout
Aug 15, 2026
Merged

zhenyuan992 merged 1 commit into
mainfrom
fix/roi-import-timeout

Conversation

@zhenyuan992

Copy link
Copy Markdown
Collaborator

What this fixes

Fiji previously used a 10-second read timeout for every bridge request. ROI import is a synchronous FLIMKit UI-thread mutation and cannot be cancelled safely. If it took longer than 10 seconds, Fiji could report a timeout while the ROI import later completed, making a retry unsafe.

This change:

  • keeps the 10-second read timeout for image GET requests
  • disables the read timeout for ROI POST requests so Fiji waits for the final result
  • adds a fast source regression for the request-specific timeout
  • delays the real Fiji ROI import by 11 seconds to prove the old timeout boundary is crossed safely
  • corrects the README's verified test count

Verification

  • real Fiji with an 11-second delayed ROI import: 29 passed
  • suite without Fiji: 28 passed, 1 skipped
  • Python compilation: passed
  • git diff --check: passed

Scope

This is a focused follow-up to merged PR #2. It does not change image transport, authentication, ROI payloads, or server binding behavior.

@zhenyuan992
zhenyuan992 merged commit 5d43d18 into main Aug 15, 2026
2 checks passed
@zhenyuan992
zhenyuan992 deleted the fix/roi-import-timeout branch August 15, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant