Repository navigation
Bump puma 8, rack-cors 3, shoulda-matchers 8 (supersedes #6, #7, #9) - #12
Merged
Merged
Conversation
…rypoint mode Supersedes Dependabot #6, #7 and #9. Batched because each of these only touches Gemfile.lock, so merging them one at a time conflicts the rest - #8 (rspec-rails) merged cleanly and immediately left #6 DIRTY. Each bump is verified on the axis the suite cannot reach, because a green suite means different things for each of them: shoulda-matchers 5.3.0 -> 8.0.1 test-only; the suite IS the verification. 75 examples, 0 failures. puma 6.6.1 -> 8.0.2 rspec never boots a server. Booted the app and confirmed puma 8.0.2 serving requests. rack-cors 2.0.2 -> 3.0.0 a MAJOR, and there are NO CORS specs in this repo at all, so a green suite says nothing about it. Issued a real preflight: 200 with allow-origin *, all seven allow-methods, allow-headers authorization, max-age 7200; a simple GET also carries allow-origin. Also fixes local development, which has been broken for anyone running docker compose here. docker-entrypoint.sh was committed mode 100644, not 100755. The Dockerfile does `RUN chmod +x docker-entrypoint.sh`, so the DEPLOYED image is fine - but docker-compose bind-mounts `.:/app`, which overlays the image's executable copy with the host's non-executable one, so every local `docker compose up` died with "exec ./docker-entrypoint.sh: permission denied" while api.foaf.io stayed healthy. Committed mode is now 100755. Refs rheos/growoperative-api#55 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes Dependabot #6, #7 and #9.
Batched deliberately: each of these only touches
Gemfile.lock, so merging them one at a time conflicts the rest — #8 (rspec-rails) merged cleanly and immediately left #6DIRTY. Three serial rebase cycles for three one-line bumps isn't a good trade.Each verified on the axis the suite cannot reach
A green suite means something different for each of these, which is the whole point:
For rack-cors I issued a real preflight rather than trusting CI:
A simple
GETwith anOriginalso carriesaccess-control-allow-origin. The existingconfig/initializers/cors.rb(origins "*", all methods) works unchanged on 3.0.Also: local development has been broken here
Not a dependency change, but found while trying to boot the app for the puma check, and worth fixing in the same PR since it blocks anyone verifying anything locally.
docker-entrypoint.shwas committed as mode 100644, not 100755. Everydocker compose upin this repo died with:The deployed image is fine, which is why nobody noticed — the Dockerfile does
RUN chmod +x docker-entrypoint.sh. Butdocker-compose.ymlbind-mounts.:/app, which overlays the image's executable copy with the host's non-executable one. Soapi.foaf.iostayed healthy while local dev was dead. Committed mode is now 100755.(Two other local-dev papercuts hit on the way, neither a repo change: the
foaf_db_datavolume still held MySQL data from before the 2026-08-22 Postgres migration, so Postgres refused toinitdb; and a staletmp/pids/server.pidpersists on the host through the bind mount. Both cleared by hand.)Refs rheos/growoperative-api#55