Missing Tie-Breaker Logic solved#95
Merged
Merged
Conversation
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
When a multiplayer game ends in a tie, the game will now correctly display a message like "It's a Tie between Players 1 & 2
instead of crashing. Single-player and single-winner games continue to display their respective victory messages correctly.
🔗 Related Issue
Closes: #92
🛠 Changes Made
In showCongratulations():
Removed the logic that attempted to use undeclared variables (tieMode, tiePlayers) and the non-existent startTieBreaker()
function.
Updated the logic to use an if/else block that gracefully handles ties by joining the winner names with " & " and displaying a
friendly message in the UI popup.
In disableBlocks():
Replaced the manual popup display with a call to showCongratulations(), ensuring the correct winner or tie message is calculated
and shown when the game ends.
📷 Screenshots (if applicable)
✅ Checklist