solved 68#71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Brief description of what this PR does.
🔗 Related Issue
Closes: #68
🛠 Changes Made
function. Instead of resetting and reusing a single audio node, the function now creates a cloneNode() for each play request. This
allows sounds like the bird's flap to overlap naturally (polyphony) and avoids the browser errors caused by interrupting a playing
track. I also included a cleanup mechanism using the onended event to remove finished clones from memory and slightly reduced the volume
of these clones to prevent audio distortion when multiple sounds layer.
📷 Screenshots (if applicable)
✅ Checklist