Skip to content

fix(ui): homepage previews, theme glass, folder open, ClickGUI clip - #189

Merged
cursor[bot] merged 2 commits into
mainfrom
cursor/edge-ui-theme-scissor-edce
Aug 30, 2026
Merged

fix(ui): homepage previews, theme glass, folder open, ClickGUI clip#189
cursor[bot] merged 2 commits into
mainfrom
cursor/edge-ui-theme-scissor-edce

Conversation

@gaoyu06

@gaoyu06 gaoyu06 commented Aug 30, 2026

Copy link
Copy Markdown
Member

Fixes Edge homepage background previews, theme switching (window stayed black), both “打开文件夹” actions, ClickGUI expanded-settings overflow, and locks Fast Render off by default.

What changed

  • Fast Render default: already false; FastRenderDefaultTest locks constructor + source default so enabling Performance does not turn it on.
  • Homepage preview cards / theme glass: EdgeCanvas.strokeRoundRect faked a stroke by filling a larger rounded rect, then cutting the interior with a hardcoded dark color. That painted over panorama previews and Theme.glass(). Stroke is now a ring (Rects.roundedOutline).
  • 打开文件夹 (background + music): FolderOpen uses explorer.exe / open / xdg-open, then on Windows raises Explorer via JNA. Missing background.png is treated as a file so the parent client dir opens.
  • ClickGUI clip: Scissor.toFramebuffer uses ScaledResolution / UiScale, flips Y, clamps. Every pushClip is intersected with the SharedClickGui panel so expanded settings stay inside the window.

Verification

  • ./gradlew test — 49 tests, 0 failures
  • ./gradlew build — BUILD SUCCESSFUL (shadowJar + remapJar)
  • In-game 1.8.9 not available in this environment

Manual 1.8.9 checks

  1. Fresh profile: Performance → 快速渲染 / Fast Render off. Enabling the module must not turn it on.
  2. Homepage background picker: each card shows the matching preview.
  3. Background and Music 打开文件夹: folder opens; on Windows, Explorer should come forward when possible.
  4. ClickGUI Dark ↔ Light: panel/window background updates (not stuck black).
  5. Expand a tall module at GUI scale 2+: settings stay clipped inside the window.

Remaining risks

  • Exclusive fullscreen can still keep Explorer behind the game.
  • Open-folder header buttons duplicate Prism layout math.
  • ClickGUI open-scale animation: scissor does not follow the GL transform (same as before; OK at scale=1).
  • Accent stays the shared indigo (Dark/Light glass, not a custom accent picker).
Open in Web Open in Cursor 

cursoragent and others added 2 commits August 30, 2026 15:44
Keep Fast Render off by default. Draw rounded strokes as a ring so
theme glass and background previews are not painted over with a hardcoded
dark fill. Convert scissor to framebuffer pixels (and clamp) so expanded
ClickGUI settings stay inside the window. Open background and local-music
folders with explorer/xdg-open and raise the Explorer window on Windows.

Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
resolveDirectory used File.isFile(), which is false for a path that
does not exist yet (background.png before the user drops one). Use the
filename as a hint so Open Folder still targets the parent directory.
Also lock Performance.fastRender's source default to false.

Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
@cursor
cursor Bot merged commit 6697bab into main Aug 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants