fix(ui): homepage previews, theme glass, folder open, ClickGUI clip - #189
Merged
Conversation
Keep Fast Render off by default. Draw rounded strokes as a ring so theme glass and background previews are not painted over with a hardcoded dark fill. Convert scissor to framebuffer pixels (and clamp) so expanded ClickGUI settings stay inside the window. Open background and local-music folders with explorer/xdg-open and raise the Explorer window on Windows. Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
resolveDirectory used File.isFile(), which is false for a path that does not exist yet (background.png before the user drops one). Use the filename as a hint so Open Folder still targets the parent directory. Also lock Performance.fastRender's source default to false. Co-authored-by: Gao Yu <gaoyu06@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Edge homepage background previews, theme switching (window stayed black), both “打开文件夹” actions, ClickGUI expanded-settings overflow, and locks Fast Render off by default.
What changed
false;FastRenderDefaultTestlocks constructor + source default so enabling Performance does not turn it on.EdgeCanvas.strokeRoundRectfaked a stroke by filling a larger rounded rect, then cutting the interior with a hardcoded dark color. That painted over panorama previews andTheme.glass(). Stroke is now a ring (Rects.roundedOutline).FolderOpenusesexplorer.exe/open/xdg-open, then on Windows raises Explorer via JNA. Missingbackground.pngis treated as a file so the parent client dir opens.Scissor.toFramebufferusesScaledResolution/UiScale, flips Y, clamps. EverypushClipis intersected with the SharedClickGui panel so expanded settings stay inside the window.Verification
./gradlew test— 49 tests, 0 failures./gradlew build— BUILD SUCCESSFUL (shadowJar + remapJar)Manual 1.8.9 checks
Remaining risks