Adding kwargs and optional signing to create chain function#14
Open
kirit93 wants to merge 34 commits intoFPriv:masterfrom
Open
Adding kwargs and optional signing to create chain function#14kirit93 wants to merge 34 commits intoFPriv:masterfrom
kirit93 wants to merge 34 commits intoFPriv:masterfrom
Conversation
added 2 commits
April 8, 2019 16:07
hannemennah
reviewed
Apr 9, 2019
| if signer_chain_id and not signer_private_key: | ||
| raise Exception("signer_private_key is required when passing a signer_chain_id.") | ||
| if not content: | ||
| raise Exception("content is required.") |
There was a problem hiding this comment.
Why was the None-check on content removed?
Author
There was a problem hiding this comment.
My bad, that was an error on my part. I realize now that the None check for content should remain.
My rationale was that since it's a compulsory function arg, there would always be some content passed by the user. But in the case the user passes in "None" the None-check would handle that.
added 26 commits
April 9, 2019 19:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Cahl-Dee this PR is with regards to the conversation we had and the issues I submitted.
Let me know your thoughts.