Robust sigproc header parsing#56
Merged
Merged
Conversation
- nsamples is a valid keyword now. header_keys is a more robust schema now. - Updated FilReader documentation to reference SIGPROC_SCHEMA instead of header_keys. - Introduced SigprocBuilder class in test_sigproc.py for constructing sigproc-format byte streams. - Enhanced test coverage for encoding and parsing headers, including edge cases for nsamples. - Added tests for editing header fields, ensuring proper handling of source_name length and character validation.
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing rule:
nsamplesis added to valid keywords (read-only). At runtime, we choose the minimum of the two (file size or metadata) and issue a warning.nsamplesis a legacy keyword (as per sigproc original documentation), sigpyproc will only support reading and not writing.