Skip to content

Claw - #1

Merged
dlaflotte merged 2 commits into
masterfrom
claw
Jul 1, 2025
Merged

Claw#1
dlaflotte merged 2 commits into
masterfrom
claw

Conversation

@Luddo183

@Luddo183 Luddo183 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@dlaflotte
dlaflotte requested a review from Copilot July 1, 2025 00:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new Claw subsystem for handling intake/outtake with motor and distance sensor, integrates it into the robot setup, and removes unused test-state machinery.

  • Implements Claw subsystem with motor I/O, sensor connectivity alerts, and WPILib commands for intake, outtake, stop, and sensor-based automatic intake.
  • Updates RobotContainer to construct and bind the new Claw in real, simulation, and test modes; adds controller button mappings.
  • Declares claw-specific constants in Constants.java and cleans up obsolete FSM code in Robot.java.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
src/main/java/org/team2342/frc/subsystems/claw/Claw.java New Claw subsystem class with motor/sensor I/O, logging, and commands
src/main/java/org/team2342/frc/RobotContainer.java Instantiates Claw per mode and adds button bindings
src/main/java/org/team2342/frc/Robot.java Removed unused PrintCommand import and FSM test code
src/main/java/org/team2342/frc/Constants.java Added ClawConstants (threshold, motor config, sim models)
Comments suppressed due to low confidence (2)

src/main/java/org/team2342/frc/subsystems/claw/Claw.java:52

  • [nitpick] Add Javadoc comments for this public method (and similarly for outtake, stop, and intakeUntilCoral) to explain its behavior and usage.
  public Command intake() {

src/main/java/org/team2342/frc/subsystems/claw/Claw.java:64

  • Add unit tests for this command sequence to verify that intake continues until the sensor threshold is reached and then stops as expected.
  public Command intakeUntilCoral() {

Comment thread src/main/java/org/team2342/frc/subsystems/claw/Claw.java
Comment thread src/main/java/org/team2342/frc/subsystems/claw/Claw.java
@dlaflotte

Copy link
Copy Markdown
Contributor

Code looks good. AI comments added.

@dlaflotte dlaflotte closed this Jul 1, 2025
@dlaflotte dlaflotte reopened this Jul 1, 2025
@dlaflotte
dlaflotte merged commit 25d1115 into master Jul 1, 2025
4 checks passed
@Luddo183
Luddo183 deleted the claw branch July 1, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants