Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a new Claw subsystem for handling intake/outtake with motor and distance sensor, integrates it into the robot setup, and removes unused test-state machinery.
- Implements
Clawsubsystem with motor I/O, sensor connectivity alerts, and WPILib commands for intake, outtake, stop, and sensor-based automatic intake. - Updates
RobotContainerto construct and bind the newClawin real, simulation, and test modes; adds controller button mappings. - Declares claw-specific constants in
Constants.javaand cleans up obsolete FSM code inRobot.java.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/org/team2342/frc/subsystems/claw/Claw.java | New Claw subsystem class with motor/sensor I/O, logging, and commands |
| src/main/java/org/team2342/frc/RobotContainer.java | Instantiates Claw per mode and adds button bindings |
| src/main/java/org/team2342/frc/Robot.java | Removed unused PrintCommand import and FSM test code |
| src/main/java/org/team2342/frc/Constants.java | Added ClawConstants (threshold, motor config, sim models) |
Comments suppressed due to low confidence (2)
src/main/java/org/team2342/frc/subsystems/claw/Claw.java:52
- [nitpick] Add Javadoc comments for this public method (and similarly for outtake, stop, and intakeUntilCoral) to explain its behavior and usage.
public Command intake() {
src/main/java/org/team2342/frc/subsystems/claw/Claw.java:64
- Add unit tests for this command sequence to verify that intake continues until the sensor threshold is reached and then stops as expected.
public Command intakeUntilCoral() {
Contributor
|
Code looks good. AI comments added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.