[bot-10] respawn configured bots / part 2#426
Open
d47081 wants to merge 11 commits intoFWGS:bot10from
Open
Conversation
Author
|
Well, in last commit have fixed players online counter and make code optimizations:
After this commit I need additional time for tests, it looks better just doubts that everything stable. |
Author
|
Last 2 commits includes:
testing.. |
Author
|
Everything works, but I found bots and players sometimes freeze / stuck - maybe after disconnection. I think this problem related with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for PR #422
Removes bot state reset on bot thinking, also the
kickedstate was changed fromBOT_IDLEtoBOT_NEED_TO_RESPAWNI think this model more useful in bot container and looks not conflicting with it logic.
That allows to respawn configured bots only (from queue not from default
BOT_IDLEslots registry)Solution looks stable, but please let me test it for few days before merge.