func_breakable shouldn't take damage when it's set to Trigger Only#462
Open
FreeSlave wants to merge 1 commit intoFWGS:masterfrom
Open
func_breakable shouldn't take damage when it's set to Trigger Only#462FreeSlave wants to merge 1 commit intoFWGS:masterfrom
FreeSlave wants to merge 1 commit intoFWGS:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When func_breakable is set to Trigger Only, it sets the
pev->takedamagetoDAMAGE_NO, but since there's no check for it inTakeDamageit still can take damage because some attacks don't check forpev->takedamagefrom outside (e.g.CheckTraceHullAttack).I'm not sure if this fix should be merged as there could be some maps that rely on such behavior.