Initial Kubernetes deployment changes#17
Conversation
|
Thanks for the PR Jack! The overall structure is solid and follows the 1. verify=False (you already flagged this) 2. validate_jwt_token() rejects modern Kubernetes tokens 3. GH_PAT not forwarded to container env vars 4. Typo: "ComputerServers" instead of "ComputeServers" The condition always evaluates False so secrets are always included in 5. ttlSecondsAfterFinished: 10 is too short for debugging 6. activeDeadlineSeconds: 300 hardcoded |
These are the initial changes for adding a certificate to the config. Going to work on testing and fixing.
|
Made more changes:
|
These are the basic changes I made to allow the backend to work with Kubernetes. Most of this is in-line with the other implementations. The most important functions are the new helpers in kubernetes_helper.py and the invoke_kubernetes function.
The biggest change I need to make before this can be considered complete is to remove the "verify=False" which is included in the call to make the POST request in make_kubernetes_request in kubernetes_helper.py. This is only included as the NRP Kubernetes cluster I am testing with uses self-signed certificates (along with local instances). There is a way to solve this issue, but it is about implementing a way to specify a certificate authority in the FaaSr config, and then ensuring the request has access to the certificate for https verification. I will work on fixing this and adding it to the pull request when I am finished.
If there are any other changes I should make, please let me know!