Implement page-based log rotation (wrapping)#16
Open
eupn wants to merge 8 commits intoFactbirdHQ:masterfrom
Open
Implement page-based log rotation (wrapping)#16eupn wants to merge 8 commits intoFactbirdHQ:masterfrom
eupn wants to merge 8 commits intoFactbirdHQ:masterfrom
Conversation
Member
|
@eupn could you fix the conflicts on this one? Then I will merge it 👍 Thanks for the great work! |
Member
|
The one thing in this PR i am not super fond about is the patched embedded-storage? Could your start out by PR'ing that one? I am a maintainer there as well, so i should be able to get the discussion going on whether it's a good idea or not, with the others. I think you should be able to auto-implement the trait as impl<T: NorFlash> EraseableStorage for T {}The alternative being to change this crate to rely on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #15.
As discussed in #13, this PR implements page-based circular storage.
Uses a modified version of
embedded-storagecrate that adds a singleErasableStoragetrait that has to be implemented for the used storage type.Fixes #13
P.S.: tested verified in hardware.