due to an out of date version of clj-tuple being included via the now…#11
Open
comprehendreality wants to merge 1 commit into
Open
due to an out of date version of clj-tuple being included via the now…#11comprehendreality wants to merge 1 commit into
comprehendreality wants to merge 1 commit into
Conversation
… out of date byte-streams dependency, clj-leveldb will fail at runtime when being required on clojure 1.9+. This is because of a newly enforced spec conform on the defn- function which the out of date clj-tuple is calling incorrectly. excluding the old clj-tuple and including the latest addresses the issue.
Author
|
lein test succeeds. instead of manually pulling in clj-tuple, i tried to pull in a newer byte-streams first, but that caused the tests to fail when trying to assert that keys deleted from the db are equal to nil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… out of date byte-streams dependency, clj-leveldb will fail at runtime when being required on clojure 1.9+. This is because of a newly enforced spec conform on the defn- function which the out of date clj-tuple is calling incorrectly.
excluding the old clj-tuple and including the latest addresses the issue.