Repository navigation
Conversation
Contributor
|
Thanks @chhhee10 for your contribution to Failproof AI! 🙌 We'd love to discuss your PR and welcome you to our community. Discord: https://discord.befailproof.ai/ |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fp issues list|count|facetsfilters for agent, environment, machine, source, alert, audit, assignee, opened date range, and title/summary text. Session/apiand API-key/v1modes share the same query contract.agent_ids,environments,machine_ids, andscope_computed_atin JSON. Facets show supported values with counts; alert/audit names render in human output and ids remain in JSON.list --alert-idrouting unless combined with new filters. Normal filtered calls make no extra request. A raw row'sagent_idskey confirms support; non-empty legacy rows warn once, while empty lists/zero counts probe facets at most once per process and warn once if missing. Positive counts make no extra request.Why / dependencies
Terminal users need the same failures-inbox scopes as the redesigned Cloud dashboard. This PR is now client-only, following the October 14 product decision: all collector changes and their feature-specific tests have been removed. Collector files and wire behaviour are identical to the PR base.
Stacked on #885 (
feat/fp-cli-parity), itself on #881. Agenteye #1074 must merge first, before this client PR.The new server retains a bare issue-list array with no filter echo. Compatibility detection uses raw
agent_idskeys before model defaults are applied. Older Cloud list/count calls remain usable with a warning when unsupported filters are detected, and missing facets uses the existing “not available on this FailproofAI Cloud yet” error.Round 2 verification
origin/feat/fp-cli-parityexactly (git diff --exit-code)./job/artifacts/round2-smoke/.6263daed: Python 3.10–3.13 full suites, fresh-wheel smoke, and security checks passed. Run: https://github.com/FailproofAI/failproofai/actions/runs/38567495197Integration notes
ci.yml.agent_ids,environments,machine_ids,scope_computed_at. Facet dimensions: agents, environments, machines, sources, alerts, audits, assignees. Most entries are{value,count}; alerts/audits are{id,name,count}.Open questions / limitations
--sinceaccepts existing presets or RFC3339;--untilaccepts RFC3339. Dates apply to issue opening.82b02ec6. Evidence:/job/artifacts/base-arm64-fixture-tests.log. These tests are not changed.feat/issue-filterswas pushed.