Fix naming for mav frame constants#1167
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GCS mission handling to use the shorter MAVLink frame enum names (e.g., GLOBAL, GLOBAL_RELATIVE_ALT) instead of the longer MAV_FRAME_* strings, aligning frame lookups and frame-based altitude logic with the revised constant naming.
Changes:
- Renames frame lookups in mission item construction from
MAV_FRAME_*to short names (GLOBAL,GLOBAL_RELATIVE_ALT). - Updates elevation-profile altitude resolution to match the short frame names (including
*_INTvariants). - Updates frame dropdown mapping and “home command” frame detection to use the short frame name.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/redux/slices/missionSlice.js | Updates default/home/fence mission item frames to use short MAVLink frame names. |
| gcs/src/missions.jsx | Updates planned home mission item frame to use GLOBAL. |
| gcs/src/helpers/missionElevationProfile.js | Updates frame-name comparisons for altitude resolution to short names and *_INT variants. |
| gcs/src/helpers/mavlinkConstants.js | Updates frame dropdown mapping to resolve numeric frame IDs from short frame names. |
| gcs/src/helpers/filterMissions.js | Updates home-command detection to identify GLOBAL frame by name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.