Skip to content

Fix naming for mav frame constants#1167

Merged
1Blademaster merged 1 commit into
mainfrom
1166-bug-cant-save-fence-file
Apr 16, 2026
Merged

Fix naming for mav frame constants#1167
1Blademaster merged 1 commit into
mainfrom
1166-bug-cant-save-fence-file

Conversation

@1Blademaster

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 16, 2026 18:53
@1Blademaster 1Blademaster linked an issue Apr 16, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GCS mission handling to use the shorter MAVLink frame enum names (e.g., GLOBAL, GLOBAL_RELATIVE_ALT) instead of the longer MAV_FRAME_* strings, aligning frame lookups and frame-based altitude logic with the revised constant naming.

Changes:

  • Renames frame lookups in mission item construction from MAV_FRAME_* to short names (GLOBAL, GLOBAL_RELATIVE_ALT).
  • Updates elevation-profile altitude resolution to match the short frame names (including *_INT variants).
  • Updates frame dropdown mapping and “home command” frame detection to use the short frame name.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gcs/src/redux/slices/missionSlice.js Updates default/home/fence mission item frames to use short MAVLink frame names.
gcs/src/missions.jsx Updates planned home mission item frame to use GLOBAL.
gcs/src/helpers/missionElevationProfile.js Updates frame-name comparisons for altitude resolution to short names and *_INT variants.
gcs/src/helpers/mavlinkConstants.js Updates frame dropdown mapping to resolve numeric frame IDs from short frame names.
gcs/src/helpers/filterMissions.js Updates home-command detection to identify GLOBAL frame by name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@1Blademaster
1Blademaster merged commit 5c989fe into main Apr 16, 2026
9 checks passed
@1Blademaster
1Blademaster deleted the 1166-bug-cant-save-fence-file branch April 16, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Can't save fence file

2 participants