Add distance measurement persistence to maps#1171
Merged
1Blademaster merged 1 commit intoApr 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves distance measurement state out of component-local state and into Redux so measurements persist on both the dashboard map and missions map while navigating/closing context menus, and adds UI support for deleting a saved measurement via context menu.
Changes:
- Add
distanceMeasurements(draft start + saved items) to bothmissionSliceanddashboardSlice, with actions/selectors to manage them. - Update the dashboard and missions map components to use Redux-backed distance measurement state and to allow deleting a saved measurement.
- Refactor
DistanceMeasurementMarkersto render persistent start/end pins, a connecting line, and a midpoint label showing the measured distance.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gcs/src/redux/slices/missionSlice.js | Adds Redux state/actions/selectors for mission-map distance measurement persistence. |
| gcs/src/redux/slices/dashboardSlice.js | Adds Redux state/actions/selectors for dashboard-map distance measurement persistence. |
| gcs/src/components/missions/missionsMap.jsx | Switches distance measurement from local state to Redux and adds “Delete distance measurement” context action. |
| gcs/src/components/mapComponents/distanceMeasurement.jsx | Reworks rendering to show persistent measurement pins/lines and a midpoint distance label. |
| gcs/src/components/dashboard/map.jsx | Switches distance measurement from local state to Redux and adds “Delete distance measurement” context action. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1Blademaster
deleted the
1169-feature-keep-distance-measurements-on-the-map
branch
April 19, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.