910 improve drone disconnect warning#911
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the drone disconnect warning system by tracking the aircraft's armed and flying states more accurately. The changes introduce proper state management for flight status and provide more informative exit warnings based on the current operational state.
Key changes:
- Added dedicated
isArmedandisFlyingstate flags with automated detection logic based on telemetry data - Enhanced exit modal to display context-aware warnings depending on whether the aircraft is flying, armed, or simply connected
- Refactored the armed state selector from a computed value to a dedicated state property
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| gcs/src/redux/slices/droneInfoSlice.js | Added telemetry fields, isArmed/isFlying state tracking, and flying detection logic based on groundspeed and altitude thresholds |
| gcs/src/components/toolbar/confirmExitModal.jsx | Implemented dynamic exit messages based on aircraft state (flying/armed/connected) |
| gcs/src/components/dashboard/telemetrySection/telemetry.jsx | Updated to use new selectIsArmed selector |
| gcs/src/components/dashboard/tabsSectionTabs/actionTabsSection.jsx | Updated to use new selectIsArmed selector |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
These changes will have to be made for mac too. Will work on it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.