Skip to content

BUG: fix arc tooltips#1585

Merged
slspencer merged 2 commits into
developfrom
fix-arc-tooltips
Jun 10, 2026
Merged

BUG: fix arc tooltips#1585
slspencer merged 2 commits into
developfrom
fix-arc-tooltips

Conversation

@DSCaskey

@DSCaskey DSCaskey commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

This PR:

  • Fixes the issue of the status bar tooltips for the Arc - Radius and Angles and the Arc - Elliptical tools disappearing.

  • Continues the process of code style changes for clarity and uniformity.

closes issue #1584

@DSCaskey DSCaskey requested review from csett86 and slspencer June 5, 2026 04:24
@DSCaskey DSCaskey self-assigned this Jun 5, 2026
@what-the-diff

what-the-diff Bot commented Jun 5, 2026

Copy link
Copy Markdown

PR Summary

  • Header Comments Update
    Updated header comments for current year and authorship in dialogarc.h and dialogellipticalarc.h
  • Method Names Standardized
    Method naming consistency established in dialogarc.h and dialogellipticalarc.h
  • Improved Variable Names
    Understandability and consistency of member variable names heightened in dialogarc.h and dialogellipticalarc.h
  • Code Cleanup
    Removed unnecessary comments and enhanced code readability in header files
  • UI Button Names Standardization
    Updated button names for consistency in dialogellipticalarc.ui
  • Code Streamlining
    Removed unused emit in dialogtool.cpp for more efficient code

@DSCaskey DSCaskey force-pushed the fix-arc-tooltips branch from 2ecc743 to 71349c5 Compare June 5, 2026 13:01

@slspencer slspencer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update valentina zhuravaska's contributions to 2016, not 2013.

Comment thread src/libs/vtools/dialogs/tools/dialogellipticalarc.h Outdated
@DSCaskey

DSCaskey commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Hey @csett86,

Any idea why the Windows builds are failing here? The PR built last week and all I did here was change some dates. The develop & feature branch ci.yml's look the same, and the CI Chrono built yesterday.

@csett86

csett86 commented Jun 9, 2026

Copy link
Copy Markdown
Member

I compared this one and yesterdays CI build https://github.com/FashionFreedom/Seamly2D/actions/runs/27112316939/job/80012441891, and its the update to VS2026 mentioned in actions/runner-images#14017

I'll raise a separate PR to fix that by pinning to windows-2022 as mentioned in actions/runner-images#14017

@csett86

csett86 commented Jun 9, 2026

Copy link
Copy Markdown
Member

@DSCaskey see #1586

@DSCaskey

DSCaskey commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @csett86... it makes sense now.

@DSCaskey DSCaskey force-pushed the fix-arc-tooltips branch from 24a0ca9 to 337a97f Compare June 9, 2026 23:28
@slspencer slspencer self-requested a review June 10, 2026 13:55
@slspencer slspencer merged commit d64ee29 into develop Jun 10, 2026
13 checks passed
@slspencer slspencer deleted the fix-arc-tooltips branch June 10, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants