Skip to content

Cli#395

Merged
Stivenjs merged 2 commits into
mainfrom
cli
Jan 17, 2026
Merged

Cli#395
Stivenjs merged 2 commits into
mainfrom
cli

Conversation

@Stivenjs
Copy link
Copy Markdown
Contributor

@Stivenjs Stivenjs commented Jan 17, 2026

Note

Introduces native module support and Rust build hygiene across the repo.

  • Adds @fasttify/liquid-forge-native to serverExternalPackages in next.config.ts
  • Ignores Rust build artifacts in .gitignore
  • Adds clean:rust, prebuild, and check-build-size scripts in root package.json
  • Includes *.node binaries in packages/liquid-forge-native/package.json files
  • Updates next-env.d.ts to reference ./.next/types/routes.d.ts

Written by Cursor Bugbot for commit 84794df. This will update automatically on new commits. Configure here.

… management and dependency handling

This commit adds Rust build artifacts to .gitignore, updates the import path in next-env.d.ts for better type resolution, and introduces new scripts in package.json for cleaning Rust build artifacts and pre-build processes. Additionally, it includes a new dependency '@fasttify/liquid-forge-native' in next.config.ts and updates the files section in the liquid-forge-native package.json to include '*.node'.
@Stivenjs Stivenjs self-assigned this Jan 17, 2026
@Stivenjs Stivenjs merged commit 243fbb5 into main Jan 17, 2026
8 checks passed
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on February 27

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Comment thread package.json
"type-check": "tsc --noEmit",
"type-check:fast": "tsc --noEmit --skipLibCheck",
"clean:rust": "rm -rf packages/liquid-forge-native/target packages/liquid-forge-native/src packages/liquid-forge-native/benches packages/liquid-forge-native/.cargo",
"prebuild": "pnpm run clean:rust",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prebuild script deletes source code instead of artifacts

High Severity

The clean:rust script removes packages/liquid-forge-native/src, benches, and .cargo directories which contain actual Rust source code and configuration, not build artifacts. The src/ directory contains the main library implementation (lib.rs, filters/text.rs, filters/html.rs with hundreds of lines of code). Since prebuild runs clean:rust before every pnpm build, this would delete all source code and break the build. Only target/ (the build output directory) is appropriate to clean.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant