Skip to content

Potential fix for code scanning alert no. 124: Incomplete URL substring sanitization #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stivenjs merged 1 commit into from
Feb 16, 2026
Merged

Potential fix for code scanning alert no. 124: Incomplete URL substring sanitization #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/app/[store]/src/components/DevAutoReloadScript.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,22 @@ export default function DevAutoReloadScript() {
links.forEach((oldLink) => {
if (!oldLink.href) return;

let parsedUrl: URL;
try {
parsedUrl = new URL(oldLink.href, window.location.origin);
} catch {
// Si la URL no es válida, no intentar hacer hot-swap.
return;
}

const hostname = parsedUrl.hostname;
const pathname = parsedUrl.pathname;

// Ignorar CSS externos (Google Fonts, CDNs, etc.)
if (
oldLink.href.includes('fonts.googleapis.com') ||
oldLink.href.includes('fonts.gstatic.com') ||
!oldLink.href.includes('/stores/')
hostname === 'fonts.googleapis.com' ||
hostname === 'fonts.gstatic.com' ||
!pathname.includes('/stores/')
) {
return;
}
Expand Down
Loading