The waiter will drain the action queue on main thread wake - #35
Open
brentfatsoma wants to merge 1 commit into
Open
The waiter will drain the action queue on main thread wake#35brentfatsoma wants to merge 1 commit into
brentfatsoma wants to merge 1 commit into
Conversation
brentfatsoma
force-pushed
the
ENG-549-waiter-queue-drain
branch
from
February 3, 2026 10:38
d2b03f6 to
969a96e
Compare
Ticket: https://fatsoma.atlassian.net/browse/ENG-549 This is part of an ongoing investigation into delivery acknowledgement timeout errors that we are intermittently experiencing in production (particularly in the ticket service). This change modifies the waiter, so that when the main thread wakes up it drains the action queue of n messages, rather than processing a single ack/nack at a time. The reasoning is that the main thread might not be keeping up with the work pushed by consumer threads, leading to acks not being sent within the 2 hour window.
brentfatsoma
force-pushed
the
ENG-549-waiter-queue-drain
branch
from
February 3, 2026 11:05
969a96e to
0952579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://fatsoma.atlassian.net/browse/ENG-549
This is part of an ongoing investigation into delivery acknowledgement timeout errors that we are intermittently experiencing in production (particularly in the ticket service). This change modifies the waiter, so that when the main thread wakes up it drains the action queue of n messages, rather than processing a single ack/nack at a time. The reasoning is that the main thread might not be keeping up with the work pushed by consumer threads, leading to acks not being sent within the 2 hour window.