Repository navigation
Conversation
RestorerRabbit
marked this pull request as ready for review
July 31, 2026 00:39
Faustvii
approved these changes
Sep 2, 2026
|
🎉 This PR is included in version 0.9.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
On PostgreSQL,
GetAllBooks()throws, so the unpaged book listing atGET /api/v1/bookreturns a 500.Two aliases in the raw SQL are declared unquoted but referenced quoted:
Postgres lowercases the unquoted declaration to
minid, while the quoted reference is case-sensitive, so it resolves to nothing:SeriesTitlehas the same mismatch: declaredas SeriesTitle, consumed assbl."SeriesTitle".This quotes the two declarations so they match their references. SQLite is unaffected because it treats identifiers case-insensitively, so the query behaves identically there before and after.
Screenshot (if UI related)
N/A
Todos
develop. The 4 failures are stale assertions against live Goodreads metadata that has since changed.Issues Fixed or Closed by this PR
N/A