Skip to content

Update filter function documentation and re-enable npm test step in CI#11

Merged
Feresaul merged 3 commits intomainfrom
workflow
May 9, 2025
Merged

Update filter function documentation and re-enable npm test step in CI#11
Feresaul merged 3 commits intomainfrom
workflow

Conversation

@Feresaul
Copy link
Copy Markdown
Owner

@Feresaul Feresaul commented May 9, 2025

No description provided.

@Feresaul Feresaul requested a review from Copilot May 9, 2025 13:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the filter function documentation to replace the "mode" parameter with a "strict" parameter description and adjusts the CI configuration by re-enabling the npm test step while removing the tag creation workflow.

  • Updated documentation for the filter function in lib/utils/filter.ts
  • Removed the tag creation workflow file
  • Re-enabled the npm test step in the npm-publish workflow

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
lib/utils/filter.ts Updated JSDoc to describe a "strict" parameter instead of "mode"
.github/workflows/tag-creation.yml Removed the legacy tag creation workflow
.github/workflows/npm-publish.yml Uncommented the npm test step to re-enable testing in CI
Comments suppressed due to low confidence (2)

.github/workflows/tag-creation.yml:1

  • Confirm that the removal of the tag-creation workflow is intentional and that any necessary functionality is covered elsewhere in the CI configuration.
File removal

.github/workflows/npm-publish.yml:16

  • [nitpick] Verify that re-enabling the npm test step in the CI is intended and that tests are stable to avoid unexpected build failures.
- run: npm test

Feresaul and others added 2 commits May 9, 2025 07:42
@Feresaul Feresaul merged commit fb6f2c6 into main May 9, 2025
1 check passed
@Feresaul Feresaul deleted the workflow branch May 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants