Long runtimes from MCMC (+ some quality of life / bugs) - #9
Open
Zstone19 wants to merge 3 commits into
Open
Conversation
…lay_dist=True of [0, baseline*5], where baseline is the maximum of the reference+line baselines. Improves performance significantly when delta_i cannot blow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without an upper limit on Δ_i when
delay_dist=True, the MCMC can cause it to blow up and increase runtimes significantly. I put in a generous upper limit of 5x(temporal baseline) on Δ_i.I also added an
nthreadsparameter, which allows the user to specify the number of threads used for the MCMC.Small bug in establishing the model time array
tfixed.