Feat/p256 authorizer - #587
Open
JAG-UK wants to merge 8 commits into
Open
Conversation
Contributor
|
Two things:
|
Contributor
Author
|
Kubuxu
reviewed
Aug 20, 2026
Kubuxu
left a comment
Kubuxu
left a comment
Contributor
There was a problem hiding this comment.
From a skim look good, let me know if you think an indepth review would be helpful or should we just assume this is correct based on tests passing.
| // IDataSetAuthorizer is inlined (not imported) so this example compiles on its own, independent of | ||
| // whether PR #536 has merged. Merge order is up to maintainers: once | ||
| // `src/interfaces/IDataSetAuthorizer.sol` exists on the target branch, replace this copy with that | ||
| // import. Keep the function signature identical to #536's interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a candidate 'standard' P256 + Passkeys authorizer for FWSS
isAuthorized()feature.In principle this could be the only one anyone ever needs to use.