Skip to content

feat: set cointype#345

Open
0Tech wants to merge 10 commits into
Finschia:fnsad-v050-legacyfrom
0Tech:config
Open

feat: set cointype#345
0Tech wants to merge 10 commits into
Finschia:fnsad-v050-legacyfrom
0Tech:config

Conversation

@0Tech

@0Tech 0Tech commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

Description

This patch would update CoinType from the original value to 438.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@0Tech 0Tech self-assigned this Mar 27, 2024
@codecov

codecov Bot commented Mar 27, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (fnsad-v050-legacy@f3545a0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
app/app.go 50.00% 2 Missing ⚠️
app/export.go 0.00% 2 Missing ⚠️
app/test_helpers.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##             fnsad-v050-legacy     #345   +/-   ##
====================================================
  Coverage                     ?   71.15%           
====================================================
  Files                        ?        8           
  Lines                        ?     1418           
  Branches                     ?        0           
====================================================
  Hits                         ?     1009           
  Misses                       ?      378           
  Partials                     ?       31           
Files with missing lines Coverage Δ
app/ante.go 58.13% <ø> (ø)
app/test_support.go 0.00% <ø> (ø)
app/test_helpers.go 61.11% <0.00%> (ø)
app/app.go 88.20% <50.00%> (ø)
app/export.go 9.81% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0Tech

0Tech commented Mar 27, 2024

Copy link
Copy Markdown
Contributor Author

Ignore CI failures for now. It would be addressed by #343.

@0Tech 0Tech marked this pull request as ready for review March 27, 2024 12:51
@tkxkd0159

tkxkd0159 commented Apr 1, 2024

Copy link
Copy Markdown
Contributor

Ignore CI failures for now. It would be addressed by #343.

@0Tech Is E2E-IBC okay to fail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants