fix(driver): sticky AMS compare accepts either RFID chip of a spool - #15
Open
wolfrage76 wants to merge 1 commit into
Open
fix(driver): sticky AMS compare accepts either RFID chip of a spool#15wolfrage76 wants to merge 1 commit into
wolfrage76 wants to merge 1 commit into
Conversation
FilaMan spools can now carry two chips (spools.rfid_uid_2, one per side). The sticky-slot check compared the tray's tag_uid against rfid_uid only, so a spool re-inserted with its second side facing the reader was treated as a different spool and lost its assignment. Match against both slots; getattr keeps the driver compatible with a FilaMan without the column. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UMQU17mLkTakENnbYH1m8M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilaMan is gaining a second RFID slot per spool (
spools.rfid_uid_2) so a spool can carry one chip per side, like Bambu spools do. The AMS reports whichever chip faces the reader, but the sticky-slot check compared the tray'stag_uidagainstspool.rfid_uidonly — a spool re-inserted with its second side facing the reader was treated as a different spool and lost its assignment.This builds the comparison set from both slots.
getattr(spool, "rfid_uid_2", None)keeps the driver working unchanged against a FilaMan without the column.The pending auto-assign path already matches on the chip the scale just scanned, so it needed no change.
Companion change
FilaMan side: second RFID slot per spool on
wolfrage76/filaman-systemdevel(bef6b18, migrationb3c7d1e9f402).Test plan
rfid_uid_2→ behaviour identical to before.🤖 Generated with Claude Code
https://claude.ai/code/session_01UMQU17mLkTakENnbYH1m8M