Fix the colors of the generic message bar button#373
Open
Rob--W wants to merge 1 commit intoFirefoxUX:masterfrom
Open
Fix the colors of the generic message bar button#373Rob--W wants to merge 1 commit intoFirefoxUX:masterfrom
Rob--W wants to merge 1 commit intoFirefoxUX:masterfrom
Conversation
The preview at `jekyll/images/message-bars/c-gen.svg` shows grey buttons (=default button style), which looks reasonable. However, the label in the image and the document's description specified a blue style that is meant to be used for the primary button. This commit fixes the discrepancy by using the colors of the button as specified `_includes/components/buttons/behaviors-default.md` , and matches the rendered message bar (c-gen.svg) TODO: Change "Blue-60" to "Grey-90-a10" at jekyll/images/message-bars/c-gen.svg
Author
|
@brassy- https://github.com/FirefoxUX/photon/blob/master/jekyll/images/message-bars/c-gen.svg was introduced in d5c213d, which is authored by you. If you approve of this PR, could you provide an updated SVG where "Blue-60" text is changed to "Grey-90-a10" (which matches the actual color of the button in the SVG)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview at
jekyll/images/message-bars/c-gen.svgshows grey buttons (=default button style), which looks reasonable. However, the label in the image and the document's description specified a blue style that is meant to be used for the primary button.This commit fixes the discrepancy by using the colors of the button as specified
_includes/components/buttons/behaviors-default.md, and matches the rendered message bar (c-gen.svg).TODO: Change "Blue-60" to "Grey-90-a10" at jekyll/images/message-bars/c-gen.svg
(I didn't change it here because those letters are a path in the vector image and not easily editable.)
Fixes #287