Skip to content

chore(changeset): track security hardening and nix completions for 1.13.1 - #1902

Merged
clay-good merged 1 commit into
mainfrom
changeset-security-and-nix
Sep 17, 2026
Merged

clay-good merged 1 commit into
mainfrom
changeset-security-and-nix

Conversation

@clay-good

@clay-good clay-good commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Status: LGTM. Changesets only, no code.

Why this is needed: a release audit against v1.13.0 found two merged, user-facing PRs with no changeset. Without them, the 1.13.1 changelog and release notes would leave them out:

PR What users get
#1835 Hardening against untrusted repositories: config.yaml prompt injection, two ReDoS hangs, .npmrc update-check hijack, hand-edited SKILL.md detection, and the broken DO_NOT_TRACK=true opt-out
#1785 Shell completions installed with the Nix flake package

Both are patch, so the version stays 1.13.1. Once this merges, the Changesets action updates the Version Packages PR #1896.

Checked and intentionally skipped (docs, tests, or dev tooling, per .changeset/README.md): #1838, #1900, #1901.

Proof: pnpm exec changeset status reports one patch bump for @fission-ai/openspec. I checked each bullet against #1835's description and its regression tests, for example test/core/update-skill-tamper.test.ts for the SKILL.md restore.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Security

    • Improved protection when working with untrusted repositories, including safer configuration handling, file processing, registry checks, shell completion paths, and Git operations.
    • Generated skills are restored when manually modified.
    • Telemetry now respects common opt-out settings and displays the first-run notice appropriately.
  • New Features

    • Nix installations now include Bash, Zsh, and Fish shell completions in standard locations, enabling tab completion without installing files into a home directory.

…tions

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@clay-good
clay-good requested a review from a team as a code owner September 17, 2026 00:28
@clay-good
clay-good requested review from TabishB and removed request for a team September 17, 2026 00:28
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: ec4665d3-901c-4087-8e93-1cf1bdf4e826

📥 Commits

Reviewing files that changed from the base of the PR and between 3312af4 and 010f3e0.

📒 Files selected for processing (2)
  • .changeset/harden-untrusted-repositories.md
  • .changeset/nix-flake-shell-completions.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds two patch changesets. One documents hardening for untrusted repositories. The other documents shell completions shipped by the Nix flake package.

Changes

Untrusted repository hardening

Layer / File(s) Summary
Hardening release note
.changeset/harden-untrusted-repositories.md
Records security and reliability fixes for untrusted repositories, including bounded git probes, safe completion paths, telemetry handling, and dependency advisory remediation.

Nix shell completions

Layer / File(s) Summary
Nix completion release note
.changeset/nix-flake-shell-completions.md
Records a patch release for @fission-ai/openspec and documents bash, zsh, and fish completions in standard share/ locations.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 010f3

The changesets document the intended hardening and Nix completion updates without introducing runtime changes or identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the two changesets: security hardening and Nix shell completions. It also states the target version, 1.13.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch changeset-security-and-nix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openspec-cloud

Copy link
Copy Markdown
Contributor

No PR-relevant drift confirmed.

AI-generated · A citation proves the line exists, not that it makes the case — verify before acting.
Checked the 0 requirements selected for this PR at 010f3e0 (255 total).
This is not a full-repository clean result; see the check for coverage and any broader findings.
View results · Click Refresh, then Scan again in the check. Or comment /openspec-cloud.

@alfred-openspec alfred-openspec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed current head 010f3e0. Both patch changesets accurately describe the merged user-facing behavior from #1835 and #1785, do not duplicate existing release notes, and aggregate to one patch bump for @fission-ai/openspec. The full CI matrix passes with no unresolved review threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants