test: stop two Windows subprocess tests timing out at 10s - #1981
Conversation
The Windows runner took 13.1s to spawn bash three times on the Version Packages push to main, tripping the 10s default. The same test ran in 0.3s and 4.2s on the two previous main runs; nothing in the code changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Fission-AI/OpenSpec/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe fixture and Git-clone tests now use 60-second timeouts. Comments describe their observed subprocess runtimes on Windows. ChangesTest Timeout Updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The change only gives two subprocess-heavy tests more time to complete; no specific merge-blocking risk is evident. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No PR-relevant drift confirmed.
|
Timed out at the 10s default on windows-pwsh three times (#1953 merge queue, two changeset-release runs); it normally takes ~2.6s there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alfred-openspec
left a comment
There was a problem hiding this comment.
Reviewed the two timeout-only test changes. The 60s overrides match existing subprocess-heavy test conventions, and all CI checks, including Windows, pass.
Status: LGTM. Test-only: one line in each of two test files. No product code, no changeset.
What was wrong: The tests themselves are fine. They time out because starting a new process on the Windows CI runner is slow and uneven: Windows process creation is expensive, and many test workers compete for the same machine. A test that normally takes about 3 s can take over 10 s when the machine is busy, which trips vitest's 10 s default and turns main red at random.
update-flake-script.test.ts(3bashspawns)cli-e2e/basic.test.tsGit-clone init test (3 CLI + 4git)How it was fixed: Each test now gets a 60 s timeout, the same per-test override the repo already uses for other tests that start processes. The assertions are unchanged.
Proof: Both files pass locally (39/39). The Windows job on this PR is the real check.
Notes:
store/git-probe-limitswas already fixed by #1900.store-remove-nestedfailed once and already has 30 s, so I left it alone.🤖 Generated with Claude Code