feat(ui): sidebar rework + ratings & favourites data layer - #50
Open
FivelSystems wants to merge 2 commits into
Open
feat(ui): sidebar rework + ratings & favourites data layer#50FivelSystems wants to merge 2 commits into
FivelSystems wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UI rework of the library sidebar plus the ratings & favourites data layer.
Sidebar redesign
Ratings & Favourites (data layer)
creator.name), so every version shares them, and persist in the local SQLiteuser_metadatatable.rating:4,rating:>=3,favorite:truetokens now match live, with autocomplete suggestions (previously these tokens were inert).SetRating/SetFavoriterepo methods, hydration onto packages inGetCachedPackages, exposed viaApp.SetPackageRating/App.SetPackageFavorite(bindings regenerated).Testing
go build ./...,go test ./...,go vet ./...npx tsc --noEmitclean;npx vitest run— all frontend tests pass (new coverage for rating/favourite matching, suggestions, anduser_metadataupsert/clamp/case-insensitivity).Notes
user_metadatawas already present.GlobalOverlays.tsxis pre-existing dead code (kept type-correct here); flagged for adopt-or-delete separately.