Potential fix for code scanning alert no. 5: Server-side request forgery - #84
Draft
aryan4859 wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 5: Server-side request forgery#84aryan4859 wants to merge 1 commit into
aryan4859 wants to merge 1 commit into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| throw new Error("Invalid redirect host"); | ||
| } | ||
|
|
||
| const response = await fetch(currentUrl.toString(), { redirect: "manual" }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/FlagForgeCTF/flagForge/security/code-scanning/5
General fix: keep user-controlled URL usage constrained by strict allowlisting not only for the initial URL, but also for any redirect target. The safest minimal approach is to disable automatic redirect following and manually process redirects with re-validation on each hop.
Best fix here (without changing intended functionality of “following redirects”): in
app/api/instagram/image/route.ts, replace the singlefetch(..., { redirect: "follow" })with a small helper that:redirect: "manual",3xx+Location), resolves next URL relative to current URL, re-validates it, and continues up to a bounded redirect count,Needed changes:
fetchWithValidatedRedirects) aboveGET.Suggested fixes powered by Copilot Autofix. Review carefully before merging.