Skip to content

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 2, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Migrates feature settings, feature value and create feature to typescript components
  • Migrates Row / FormGroup to fix imports
  • Simplifies interface around the create feature modal, this will eventually mean the RTK/redux store no longer needs to create new objects
    • Editing project/feature related stuff is adjusting the ProjectFlag with a single onChange
    • Editing the remote config, enabled state and MV percentages is adjusting a FeatureState with a single on Chnange
  • Minor: add tag button same height as tags
image

How did you test this code?

E2E covers regression testing on everything this affects

kyle-ssg and others added 30 commits August 5, 2025 16:27
Co-authored-by: Zaimwa9 <wadii.zaim@flagsmith.com>
# Conflicts:
#	frontend/web/components/pages/UserPage.tsx
# Conflicts:
#	frontend/common/services/useProjectFlag.ts
#	frontend/web/components/PanelSearch.tsx
#	frontend/web/components/feature-override/FeatureOverrideRow.tsx
#	frontend/web/components/modals/CreateFlag/index.js
#	frontend/web/components/pages/UserPage.tsx
#	frontend/web/components/segments/AssociatedSegmentOverrides.tsx
talissoncosta
talissoncosta previously approved these changes Dec 9, 2025
this.input.focus()
this.focusTimeout = null
}, 500)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting on the radar this might create a conflict once merged (L232 here):
#6404

# Conflicts:
#	frontend/web/components/modals/create-feature/index.js
#	frontend/web/components/pages/FeaturesPage.js
@cursor
Copy link

cursor bot commented Dec 16, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Issue related to the REST API chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants