Skip to content

chore: permission types #6417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kyle-ssg wants to merge 8 commits into
base: feat/edit-versioned-change-request
Choose a base branch
from
Open

chore: permission types #6417

kyle-ssg wants to merge 8 commits into from
+369 −123

Conversation

@kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 16, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

How did you test this code?

E2E, checking each usage of permission

Note: due to amount of refactoring I've done, I've pointed this to the latest branch I've been working on

@kyle-ssg
Enumerate permission types
a89df89
@kyle-ssg
Merge branch 'feat/edit-versioned-change-request' into chore/permissi…
ae5582e 
…on-types

# Conflicts:
#	frontend/common/providers/Permission.tsx
#	frontend/web/components/modals/create-feature/index.js
@kyle-ssg
Merge branch 'feat/edit-versioned-change-request' into chore/permissi…
0313fd7 
…on-types

# Conflicts:
#	frontend/web/components/modals/create-feature/index.js
@kyle-ssg
Migrate permissions to enum
7b4029c
@kyle-ssg
Migrate permissions to enum
6bc28f1
@kyle-ssg
Small typos
512696b
@kyle-ssg
Fix identity override permission
2afaba5
@kyle-ssg kyle-ssg requested a review from a team as a code owner December 16, 2025 15:42
@kyle-ssg kyle-ssg requested review from talissoncosta and removed request for a team December 16, 2025 15:42
@vercel
Copy link

vercel bot commented Dec 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
flagsmith-frontend-preview Ready Ready Preview, Comment Dec 16, 2025 3:42pm
flagsmith-frontend-staging Ready Ready Preview, Comment Dec 16, 2025 3:42pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Ignored Ignored Dec 16, 2025 3:42pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-6417 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-6417 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-6417 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-6417 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-6417 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-6417 Finished ✅ Results ✅

@kyle-ssg kyle-ssg changed the title Chore/permission types chore: permission types Dec 16, 2025
@kyle-ssg kyle-ssg requested a review from Zaimwa9 December 16, 2025 15:52
@kyle-ssg kyle-ssg linked an issue Dec 16, 2025 that may be closed by this pull request
Permission check for editing an identities feature needs "UPDATE_FEATURE_STATE" permission #6415
Open
4 tasks
@github-actions github-actions bot added the chore label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talissoncosta talissoncosta Awaiting requested review from talissoncosta talissoncosta is a code owner automatically assigned from Flagsmith/flagsmith-front-end

@Zaimwa9 Zaimwa9 Awaiting requested review from Zaimwa9

Assignees

No one assigned

Labels

chore front-end Issue related to the React Front End Dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Permission check for editing an identities feature needs "UPDATE_FEATURE_STATE" permission

2 participants

@kyle-ssg