Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors and extends the server update logic across the repository, API, and worker crates. It splits the previous monolithic
update_serverandupdate_serversmethods into more granular, purpose-specific operations, introduces a newServerStatusUpdatestruct to streamline status updates, and updates all call sites to use the new methods. This improves code clarity, maintainability, and safety when updating server records.Repository API refactor and new update methods:
ServerStatusUpdatestruct and changed bulk server status updates to useupdate_servers_status, which only updates relevant fields and respects forced favicon logic. [1] [2] [3]Repositorytrait and its Postgres implementation for renaming servers (rename_server), setting hidden status (set_server_hidden), updating favicons (set_server_favicon), and updating server addresses (update_server_address). [1] [2]API endpoint updates:
Worker and ping logic improvements:
refresh_endpointhelper and to update only the necessary fields via the new status update mechanism, improving efficiency and correctness. [1] [2] [3] [4] [5]These changes collectively make server updates safer and more explicit, reduce the risk of accidental data loss, and improve the maintainability of the codebase.