Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes dependency updates, improvements to error handling, and code cleanups across several backend components. The most significant change is the enhancement of the
BlockedEndpointerror to support multiple IP addresses and improved error messaging. Additionally, theminecraft-pingerdependency is upgraded, and several code formatting and minor logic improvements are made for clarity and maintainability.Error handling improvements:
AppError::BlockedEndpointvariant now accepts aVec<IpAddr>instead of a singleString, and its error message displays all blocked IPs as a comma-separated list. Unit tests are added to verify this behavior.format_blocked_ipsto render blocked IPs for error messages.Dependency updates:
minecraft-pingercrate from version0.1.10to1.0.0inCargo.toml.Code cleanups and formatting:
update_server_status,update_server_ip, andping_worker). [1] [2] [3] [4]JavaPingConfigby removing unnecessary.to_builder()conversions in multiple locations. [1] [2] [3]Repository logic consistency:
PostgresRepository. [1] [2]