Skip to content

Upgrade Minecraft pinger functionality - #136

Merged
Flash303 merged 1 commit into
mainfrom
dev
Oct 25, 2026
Merged

Flash303 merged 1 commit into
mainfrom
dev

Conversation

@Flash303

Copy link
Copy Markdown
Owner

This pull request includes dependency updates, improvements to error handling, and code cleanups across several backend components. The most significant change is the enhancement of the BlockedEndpoint error to support multiple IP addresses and improved error messaging. Additionally, the minecraft-pinger dependency is upgraded, and several code formatting and minor logic improvements are made for clarity and maintainability.

Error handling improvements:

  • The AppError::BlockedEndpoint variant now accepts a Vec<IpAddr> instead of a single String, and its error message displays all blocked IPs as a comma-separated list. Unit tests are added to verify this behavior.
  • Added a helper function format_blocked_ips to render blocked IPs for error messages.

Dependency updates:

  • Upgraded the minecraft-pinger crate from version 0.1.10 to 1.0.0 in Cargo.toml.

Code cleanups and formatting:

  • Refactored several method calls to improve readability (e.g., chaining method calls over multiple lines in update_server_status, update_server_ip, and ping_worker). [1] [2] [3] [4]
  • Simplified the construction of JavaPingConfig by removing unnecessary .to_builder() conversions in multiple locations. [1] [2] [3]

Repository logic consistency:

  • Minor formatting changes in SQL queries for updating server information in PostgresRepository. [1] [2]

@Flash303
Flash303 merged commit 33ba246 into main Oct 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant