Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves theme support in the frontend by ensuring that both the application's UI and Clerk authentication components respond to the selected light or dark theme. The main changes involve integrating Clerk's shared UI theme handling, updating CSS for color scheme support, and adding the
@clerk/uidependency.Theme integration and Clerk UI improvements:
ThemedClerkProvidercomponent inroot.tsxto dynamically set Clerk's appearance theme based on the current app theme, ensuring Clerk's UI matches the selected light or dark mode.root.tsxto wrap the app withThemedClerkProviderand ensure proper context provider order.@clerk/uidependency topackage.jsonto enable Clerk's shared UI theming.CSS and color scheme support:
index.cssto set thecolor-schemeproperty for both light (:root) and dark (.dark) themes, improving native form control and scrollbar theming. [1] [2]Code organization:
root.tsxto includeuseThemeanddarktheme from Clerk UI for theme detection and switching.