test(pinned): use mapped memory for UVA pointer check - #125
Open
huo-ju wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alloc_pinned_tensorintest_host_device_ptr_is_identity_under_uvahost_device_ptrcontractWhy
On Linux/UVA with CUDA 13,
cudaHostGetDevicePointerrejects an unregistered pageable host pointer withcudaErrorInvalidValue. The existing test passes a pageable tensor, contradicting the pinned + mapped contract ofhost_device_ptrand failing before pointer identity can be checked.This is a test-only change; runtime code is unchanged.
Testing
Environment:
nvccV13.3.73)Commands:
Results:
origin/mainatbd372b6: targeted test failed withcudaHostGetDevicePointer failed ... invalid argumentcb44bde: targeted test passed (1 passed)cb44bde: complete pinned-memory test file passed (8 passed)