Skip to content

ci: draft gate, per-run main concurrency, pinned security scan - #2

Merged
Shahrum Amiri (ShahrumAmiri) merged 2 commits into
mainfrom
tuneup/1024-storyquest-standard
Oct 24, 2026
Merged

Shahrum Amiri (ShahrumAmiri) merged 2 commits into
mainfrom
tuneup/1024-storyquest-standard

Conversation

@ShahrumAmiri

@ShahrumAmiri Shahrum Amiri (ShahrumAmiri) commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

What

  • Draft gate. pull_request now also fires on ready_for_review, and the lint job's first step fails a draft run red. The full suite runs once, when the PR is ready.
  • Main concurrency. Each push to main gets its own group (ci-main-run-<run_id>), so main runs no longer queue behind each other. PR refs still cancel superseded runs.
  • Security job. gitleaks is pinned to a constant SHA-256 instead of a checksums file fetched next to the tarball. It scans history reachable from HEAD plus the working tree, and fails closed on a shallow clone. A semgrep SAST pass (ERROR severity) is added. OSV-Scanner is left out because the repo has no dependency manifest.

The job names are unchanged (Lint & syntax check, security), so the required checks still match.

Verify

CI on this PR runs the new security steps for the first time. If semgrep reports an ERROR-level finding in existing code, it goes red here before anything merges.

🤖 Generated with Claude Code

- pull_request now listens for ready_for_review, and a first "Draft gate"
  step fails draft runs red so the full suite runs once, when the PR is
  ready.
- Pushes to main each get their own concurrency group instead of queueing.
- The security job pins gitleaks to a constant SHA-256 (it used to trust a
  checksums file fetched beside the tarball), scans history reachable from
  HEAD plus the working tree, fails closed on a shallow clone, and adds a
  semgrep SAST pass.
- docs/adr/conventions.md: how the decision log is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the generated docs/adr/conventions.md and neutralize one comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ShahrumAmiri
Shahrum Amiri (ShahrumAmiri) merged commit a173233 into main Oct 24, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant