Skip to content

feat(VPC): add secgroup_rule_v2 data source#1068

Open
alexissellier wants to merge 2 commits into
FlexibleEngineCloud:masterfrom
alexissellier:feat/add-secgroup-rule-data
Open

feat(VPC): add secgroup_rule_v2 data source#1068
alexissellier wants to merge 2 commits into
FlexibleEngineCloud:masterfrom
alexissellier:feat/add-secgroup-rule-data

Conversation

@alexissellier

Copy link
Copy Markdown

What this PR does / why we need it:
Add data source for secgroup_rule_v2

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • [*] Tests added/passed.
  • [*] Documentation updated.
  • [*] Schema updated.

Acceptance Steps Performed


make testacc TEST='./flexibleengine/' TESTARGS='-run TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic'
=== RUN   TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic
--- PASS: TestAccFlexibleEngineNetworkingSecGroupRuleV2DataSource_basic (38.66s)
PASS
ok  	github.com/FlexibleEngineCloud/terraform-provider-flexibleengine/flexibleengine	38.685s

@ShiChangkuo

Copy link
Copy Markdown
Collaborator

@alexissellier Thank you for the pull request.

it's very appreciate if we add a new data source with plural format, such as flexibleengine_compute_instances, which is more convenient for users.

@alexissellier

Copy link
Copy Markdown
Author

Hi @ShiChangkuo ,

Noted, I will add a flexibleengine_networking_secgroup_rules data source

@chengxiangdong

Copy link
Copy Markdown
Contributor

/retitle feat(VPC): add secgroup_rule_v2 data source

@github-actions github-actions Bot changed the title add secgroup_rule_v2 data source feat(VPC): add secgroup_rule_v2 data source Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants