Enhance pipeline DAG visibility, add scene-count stat, and minor lint/cleanup#5
Open
Flintcore wants to merge 1 commit into
Open
Enhance pipeline DAG visibility, add scene-count stat, and minor lint/cleanup#5Flintcore wants to merge 1 commit into
Flintcore wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
docs/engineering-optimization-plan.mdoutlining quality, observability, and product UX recommendations.PromptConfigFormby removing an unused exception variable in thecatchblock to reduce lint warnings.ProjectStatsto rename theImageimport toImageIcon, add a newClapperboardcard for "场次数" (scene/clip count), and adjust the responsive grid to accommodate the extra card.PipelineDagViewby dropping the unusedsetEdgesvariable, auto-selecting the backend-providedcurrentPhase, computing phase-level metrics (completed/running/failed/total/progress), and rendering a progress bar and current-phase badge in the DAG header.Testing
npm run lintacross the changed files and resolved the reported warnings so lint completed successfully.npm run build, which completed without errors.npm test, and the suite passed without failures.Codex Task
Note
Low Risk
Low risk UI/UX changes plus small lint cleanups; main risk is minor display/selection logic regressions in the DAG view (e.g., incorrect phase auto-selection or progress counts).
Overview
Improves workflow observability in the workspace by enhancing the pipeline DAG header: it now auto-selects the backend
currentPhase, shows an explicit “当前阶段” badge, and renders a progress bar with completed/total plus running/failed counts.Extends the project stats panel with a new “场次数” card (using
clipCount) and updates the icon import (Image->ImageIcon) and responsive grid to fit the additional metric.Also includes small maintainability cleanups (remove unused
setEdges, simplifycatchinPromptConfigForm) and addsdocs/engineering-optimization-plan.mdoutlining follow-up engineering/product optimization recommendations.Reviewed by Cursor Bugbot for commit 5ff0005. Bugbot is set up for automated code reviews on this repo. Configure here.