Skip to content

fix: download audio track choice, region-blocked Subscriptions rows, Library crash and long buffers - #1446

Merged
A-EDev merged 9 commits into
mainfrom
fix/dub-downloads-geo-subs-music-crash-buffer
Oct 26, 2026
Merged

A-EDev merged 9 commits into
mainfrom
fix/dub-downloads-geo-subs-music-crash-buffer

Conversation

@A-EDev

@A-EDev A-EDev commented Oct 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Downloads keep the audio track that was picked. Every dub of a video shares itag 140, and the download worker matched the itag before the track, so it saved whichever dub sorted first.
  • The Video tab of the compact download dialog gets an Audio Track field, so a video can be saved with the original or any dub. Audio-only downloads default to the original track, and the original is listed first.
  • Hide unplayable videos from Subscriptions now hides removed, members-only and region-blocked videos after a failed play, and region-blocked uploads that the existing duration lookup flags (no new requests). The hidden list holds 1,000 ids instead of 300.
  • Library and Music open when the music service is disabled on the device. Playing a song shows a message instead of crashing.
  • Custom buffers longer than the stock profiles now take effect, within a heap-scaled byte budget. The stock profiles keep their old byte targets. The minimum slider ends at the player's 20 s cap, and the screen says changes apply on the next start.

Related issue

Closes #1444
Closes #1443
Closes #1439
Closes #1438

Change type

  • Bug fix
  • Feature
  • Refactor or maintenance
  • Build, packaging, or CI
  • Documentation

Validation

  • ./gradlew :app:assembleGithubDebug: passed
  • ./gradlew :app:testGithubDebugUnitTest: 4,418 tests, 0 failures, 3 skipped
  • I ran any additional flavor-specific build or test tasks affected by this change: ./gradlew ktlintCheck and ./gradlew :app:compileFossDebugKotlin passed, python3 .github/scripts/nightly_notes.py --check passed.
  • I manually tested the affected behavior on an Android device or emulator.

Test device and Android version: POCO X6 Pro (2311DRK48G), Android 16

Screenshots or recordings

Risk and compatibility

  • No Room or preference migration. The unplayable list keeps its key and format; only its cap grows.

  • The Subscriptions duration lookup now asks /player in en-US so the refusal reason can be read. /player titles are never translated, so cards keep their titles.

  • A long Custom buffer holds up to 1/5 of the app heap (51 MB on a 256 MB heap). Devices Android flags as low-RAM keep the 18 s cap. Default profiles use the same byte targets as before.

  • Buffer settings now reload whenever the video player is rebuilt.

  • The change does not introduce secrets, private data, or unexpected telemetry.

  • New user-facing text uses Android string resources.

  • Dependency and lockfile changes are intentional and limited to this PR.

  • Room schema changes include the required version bump and migration, or this PR does not change the Room schema.

  • Breaking changes and upgrade steps are clearly documented.

Copilot AI balanced review requested due to automatic review settings October 25, 2026 21:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions github-actions Bot added documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces labels Oct 25, 2026
@A-EDev
A-EDev merged commit cd505e8 into main Oct 26, 2026
9 checks passed
@A-EDev
A-EDev deleted the fix/dub-downloads-geo-subs-music-crash-buffer branch October 29, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation player Video and audio playback ui Compose UI, theming, or Material 3 surfaces

Projects

None yet

2 participants