Repository navigation
fix: headphones resume, Home launch and the download menu (#1450, #1447, #1432, #1382) - #1452
Merged
Merged
Conversation
…ter Close or a video
…load quality selected first
…ed behind a New videos button
…mes a sheet, both open under the video in the player
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DownloadSheetFrame: a modal sheet from menus, and in the video player and Shorts the sameFlowBottomSheetas comments and the description, so they open under the video. Their tiles and buttons use a darker container there so they stand apart from the sheet.Related issue
Closes #1450
Closes #1447
Closes #1432
Closes #1382
Change type
Validation
./gradlew :app:assembleGithubDebugpassed./gradlew :app:testGithubDebugUnitTestpassed (4,439 tests, 0 failures, 2 skipped)ktlintCheck,:app:compileFossDebugKotlin,:app:compileGithubDebugAndroidTestKotlin,python3 .github/scripts/nightly_notes.py --checkall passedTest device and Android version: POCO X6 Pro 5G, Android 16; Resizable emulator (tablet)
Screenshots or recordings
Risk and compatibility
New preferences
resume_from_headphones(default on) anddownload_ask_every_time(default on), so current behaviour is kept until changed. The headphone resume state is a marker file so the media button path can read it synchronously.No Room schema change.
The change does not introduce secrets, private data, or unexpected telemetry.
New user-facing text uses Android string resources.
Dependency and lockfile changes are intentional and limited to this PR.
Room schema changes include the required version bump and migration, or this PR does not change the Room schema.
Breaking changes and upgrade steps are clearly documented.