Repository navigation
fix(home): Live chip shows streams for a viewer with no interests - #1461
Merged
Merged
Conversation
- the Live chip searched only the viewer's top interests, so with none it searched nothing and came back empty, then hid itself - fall back to a plain "live" search; interest searches are unchanged
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Live chip on Home built its search queries from the viewer's interests. With no interests the query list was empty, so no search ran, the chip came back empty and Home hid it.
liveQueries(interests)keeps the top-interest queries and falls back to a genericlivequery when there are none.HomeChipFeeds.live()uses it. Behavior with interests is unchanged.Related issue
Closes #1459
Change type
Validation
./gradlew :app:assembleGithubDebug./gradlew :app:testGithubDebugUnitTest— not run in full on this commit; ran--tests '*HomeChipPoliciesTest'(2 new tests forliveQueries) and it passed./gradlew spotlessCheckandpython3 .github/scripts/nightly_notes.py --checkpassTest device and Android version: Google Pixel 6, Android 16 (API 36). Fresh app data, onboarding skipped with 0 interests, then the Live chip: empty on
bad74d4e4, shows live streams with this change.Screenshots or recordings
Before and after screenshots below.
Risk and compatibility
No database, preference, permission or background-work change. One extra generic search on the Live chip only when the viewer has no interests.